Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (16c04b0) to head (b41253e).
Report is 63 commits behind head on master.

@@             Coverage Diff             @@
##              master     #2064   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1774      1774           
===========================================
  Files            183       183           
  Lines           4782      4782           
===========================================
  Hits            4782      4782           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I think it makes sense for a file finder to handle file extensions in a case-insensitive manner, especially in scenarios where the target operating system or use case does not enforce case sensitivity. This is particularly important because:

1. Cross-Platform Consistency: Different operating systems handle case sensitivity differently. For example:

   • Windows and macOS treat file extensions as case-insensitive.
   • Linux is case-sensitive. Making the file finder case-insensitive ensures predictable behavior across all platforms.

2. User Convenience: Users might unintentionally create files with mixed-case extensions (e.g., .MD vs .md). A case-insensitive approach avoids confusion and ensures files are found regardless of how the extension is written.

3. Practicality: When searching by extension, the intent is generally to match all files of a certain type, not to differentiate based on casing.

I think we should sort the output in the method too to further normalize different file systems. It takes just 0.010ms to sort 100 files, so that's fully acceptable.

Better to have paths relative to the project root to follow the conventions, and how we will use it. Especially since it's a drop in replacement for the smart glob method which is relative to the project.

Okay, I think this is ready for merge, and assuming the root cause of the two suspected related issues is GLOB_BRACE, this should fix those.

• @clifmo could you confirm if this branch fixes your issue BuildService finding non-existent files to copy in Debian framework#662? (unless the cause was Docker being weird, this should fix your issue, as it doesn't match directories)
• @sobi3ch could you confirm if this branch fixes your issue Undefined constant "Hyde\Foundation\Kernel\GLOB_BRACE" hyde#270 (pretty sure it will)

To test this, run the following command in your project terminal:

composer require hyde/framework:dev-replace-glob-brace-preview

Then rerun the reproduction steps that led to your issues.

If either of you don't have time to test it, that's totally okay, just let me know. I will be going out of town for a few days and will hold of on merging this until then as I can't properly support a release rollout until the end of the week.

@caendesilva works like a charm

@caendesilva works like a charm

@sobi3ch Thank you so much for taking the time to test it! I'll be going ahead and merge this, and I will try for a weekend release, if not earlier!